- Sep 10, 2020
-
-
Richard Lau authored
Notable changes: Node.js 14.10.0 included a streams regression with async generators and a docs rendering regression that are being fixed in this release. PR-URL: https://github.com/nodejs/node/pull/35137
-
Rich Trott authored
A previous change altered the rendering of visited links. This restores it. PR-URL: https://github.com/nodejs/node/pull/35108 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
- Sep 09, 2020
-
-
Richard Lau authored
This reverts commit 4bb40078.
-
- Sep 08, 2020
-
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/35023
-
- Sep 07, 2020
-
-
Richard Lau authored
Notable changes: - buffer: also alias BigUInt methods (Anna Henningsen) https://github.com/nodejs/node/pull/34960 - crypto: add randomInt function (Oli Lalonde) https://github.com/nodejs/node/pull/34600 - perf_hooks: add idleTime and event loop util (Trevor Norris) https://github.com/nodejs/node/pull/34938 - stream: simpler and faster Readable async iterator (Robert Nagy) https://github.com/nodejs/node/pull/34035 - stream: save error in state (Robert Nagy) https://github.com/nodejs/node/pull/34103 PR-URL: https://github.com/nodejs/node/pull/35023
-
Robert Nagy authored
Reimplement as an async generator instead of a custom iterator class. Backport-PR-URL: https://github.com/nodejs/node/pull/34887 PR-URL: https://github.com/nodejs/node/pull/34035 Refs: https://github.com/nodejs/node/issues/34680 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Robert Nagy authored
Useful for future PR's to resolve situations where e.g. finished() is invoked on an already errored streams. PR-URL: https://github.com/nodejs/node/pull/34103 Backport-PR-URL: https://github.com/nodejs/node/pull/34887 Refs: https://github.com/nodejs/node/issues/34680 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Present tense should be default choice. It is usually easier to read and understand. Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs PR-URL: https://github.com/nodejs/node/pull/35068 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Rich Trott authored
Inline a function that only gets called in the constructor. Make call to `super()` more straightforward in the process by removing conditional involving the function as it only ever returns `undefined` or else throws. That made the code a little hard to understand, as without looking at the function, one would likely expect it to return `true` on success rather than `undefined`. PR-URL: https://github.com/nodejs/node/pull/35064 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node/pull/34600 PR-URL: https://github.com/nodejs/node/pull/35052 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: https://github.com/nodejs/node/pull/35061 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35041 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node/pull/34600 Co-authored-by:
Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35049 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Tobias Nießen authored
The `2^n` notation is common in mathematics, but even then it often requires parentheses or braces. In JavaScript and C++, the `^` operator stands for bitwise xor, and should be avoided in the docs. In code tags, the JavaScript operator `**` can be used. Otherwise, the `sup` tag can be used for formatting. PR-URL: https://github.com/nodejs/node/pull/35050 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Benjamin Coe authored
Original commit message: [coverage] IncBlockCounter should not be side-effect Incrementing coverage counter was triggering EvalError for evaluateOnCallFrame when throwOnSideEffect is true. R=jgruber@chromium.org, sigurds@chromium.org, yangguo@chromium.org Bug: v8:10856 Change-Id: I0552e19a3a14ff61a9cb626494fb4a21979d535e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2384011 Commit-Queue: Benjamin Coe <bencoe@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#69628} Refs: https://github.com/v8/v8/commit/6be2f6e26e8ddfbc1a48c510672b319809674a34 PR-URL: https://github.com/nodejs/node/pull/35055 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/34875 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/34931 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com>
-
Antoine du HAMEL authored
Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: https://github.com/nodejs/node/pull/35062 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Derek Lewis authored
This patch improves the means by which the docs are viewed locally. * Remove extraneous code in the `docserve` Makefile target * Document the `docserve` task for all to know * Bring all code snippets in this section up to speed * Clarify the purpose of each documentation browsing method Fixes: https://github.com/nodejs/node/issues/34977 PR-URL: https://github.com/nodejs/node/pull/34986 Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Antoine du HAMEL authored
Adds doc output directory as order-only prerequisite for build target. PR-URL: https://github.com/nodejs/node/pull/35060 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Rich Trott authored
Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: https://github.com/nodejs/node/pull/35063 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
Change _cb_ to _callback_ to align with documentation. This is so that stack traces and error messages align with the documentation. If the documentation says "callback", then the stack traces and error messages should indicate that "callback" needs to be function or whatever, rather than "cb". PR-URL: https://github.com/nodejs/node/pull/35054 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
Remove incorrect second `#` in URl. PR-URL: https://github.com/nodejs/node/pull/35043 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Anna Henningsen authored
This ensures that no operations will be running on the libuv threadpool, which is important because they may run into race conditions with the global destructors being triggered from `exit()`, such as in the added test example here. PR-URL: https://github.com/nodejs/node/pull/35021 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/35034 Refs: https://github.com/nodejs/node/pull/34955 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Milad Farazmand authored
Original commit message: PPC: Optimize clearing higher bits of mulhw/mulhwu Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468 Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69343} Refs: https://github.com/v8/v8/commit/3f071e3e7e15af187267af6c3b369029e27c8cf5 PR-URL: https://github.com/nodejs/node/pull/35036 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/35040 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
In one context, `<Buffer>` was being interpretted as an HTML tag and not displayed. PR-URL: https://github.com/nodejs/node/pull/35032 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/35029 PR-URL: https://github.com/nodejs/node/pull/35031 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Adding backticks to an entry that has them missing in the header, unlike the other entries. PR-URL: https://github.com/nodejs/node/pull/35030 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
URL hashes cannot contain `#`. Use hashes for the locations that were intended. PR-URL: https://github.com/nodejs/node/pull/35028 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Shigma authored
PR-URL: https://github.com/nodejs/node/pull/34980 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Victory Osikwemhe authored
PR-URL: https://github.com/nodejs/node/pull/34999 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/34996 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/34902 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Change background color of Stability 1 banner. Previous color contrast of 3.61:1 fails WCAG AA. New color contrast of 4.50:1 passes. PR-URL: https://github.com/nodejs/node/pull/35047 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/35024 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Anna Henningsen authored
This is just an extra safeguard – no JS should run once we’ve decided that we are going to shutdown the process, but we’re opening a handle scope in order to access V8, so make sure that our operations do not lead to JS accidentally being run. PR-URL: https://github.com/nodejs/node/pull/35020 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
KuthorX authored
PR-URL: https://github.com/nodejs/node/pull/34233 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/34955 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-