- Jan 12, 2016
-
-
Myles Borins authored
Notable Changes: * Minor performance improvements: - module: move unnecessary work for early return (Andres Suarez) https://github.com/nodejs/node/pull/3579 * Various bug fixes * Various doc fixes * Various test improvements PR-URL: https://github.com/nodejs/node/pull/4626
-
Rich Trott authored
`fork` is imported twice in a row. Remove duplication. PR-URL: https://github.com/nodejs/node/pull/4634 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Evan Lucas authored
This comment was added with an assumption that we could determine the IP address that localhost should resolve to without performing a lookup. This was a false assumption and should be removed. PR-URL: https://github.com/nodejs/node/pull/4648 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Fedor Indutny authored
Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: https://github.com/nodejs/node/pull/4624 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Robert Jefe Lindstaedt authored
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: https://github.com/nodejs/node/pull/4609 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
James M Snell <jasnell@gmail.com>>
-
Rich Trott authored
In lib/_http_client.js, the variable `conn` was declared with the `var` keyword three times in the same scope. This change eliminates the variable entirely. PR-URL: https://github.com/nodejs/node/pull/4612 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Remove redeclarations of variables in node.js. This includes removing one apparently unnecessary `NativeModule.require('module')`. PR-URL: https://github.com/nodejs/node/pull/4605 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: https://github.com/nodejs/node/pull/4611 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Andres Suarez authored
The exts and trailingSlash variables are only used if the path isn't cached. This commit moves them further down in the code, and changes from var to const. PR-URL: https://github.com/nodejs/node/pull/3579 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Rich Trott authored
A few tests in test/gc include the http module twice. Remove duplicate require(). PR-URL: https://github.com/nodejs/node/pull/4606 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Richard Sun authored
The docs were recently refactored, and some "above" and "below" references were no longer accurate. This commit removes many such references, and replaces others with links. PR-URL: https://github.com/nodejs/node/pull/4499 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Roman Reiss authored
- Changed colors to match frontpage as close as possible. - Links are slightly more horizontally padded as compared before to accomodate for the hover effect. - Slightly reduced the scroll indication height on the TOC. - The main content is now offset using margin instead of the previous border hack. - remove empty footer that was rendering a dark bar on the bottom of each page without any content. PR-URL: https://github.com/nodejs/node/pull/4621 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
zoubin authored
PR-URL: https://github.com/nodejs/node/pull/4617 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rich Trott authored
Remove unnecessary `setImmediate()` that causes a minor race condition. Stop the test after 3 occurrences rather than 5 to allow for slower hosts running the test in parallel with other tests. Fixes: https://github.com/nodejs/node/issues/4559 PR-URL: https://github.com/nodejs/node/pull/4599 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Wyatt Preul authored
Fixes: https://github.com/nodejs/node/issues/4532 PR-URL: https://github.com/nodejs/node/pull/4535 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Sequoia McDowell authored
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: https://github.com/nodejs/node/pull/4589 Fixes: https://github.com/nodejs/node/issues/4576 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Sequoia McDowell authored
The server method returns `self` in order to allow chaining. PR-URL: https://github.com/nodejs/node/pull/4590 Fixes: https://github.com/nodejs/node/issues/4571 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
James M Snell authored
Missed on the previous review, minor line wrapping nit PR-URL: https://github.com/nodejs/node/pull/4588 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Josh Dague authored
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: https://github.com/nodejs/node/pull/4580 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Minwoo Jung authored
fix description about the latest LTS release download page to make it clear PR-URL: https://github.com/nodejs/node/pull/4583 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Santiago Gimeno authored
It avoids the creation of unnecessary handles. This issue is causing intermitent failures in `test-cluster-disconnect-race` on `FreeBSD` and `OS X`. The problem is that the `worker2.disconnect` is being called on the master before the `queryServer` is handled, causing the worker to be deleted, then the Server handle is created afterwards. Later on, when `removeWorker` is called from the `exit` handler, there are no workers left, but one handle, thus the `AssertionError`. Add a new `test/sequential/test-cluster-disconnect-leak` based on `test-cluster-disconnect-race` that creates lots of workers and fails consistently without this patch. PR-URL: https://github.com/nodejs/node/pull/4465 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Evan Lucas authored
Adds Evan Lucas and his public key to the README for releases PR-URL: https://github.com/nodejs/node/pull/4579 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Myles Borins authored
Adds Myles Borins and his public key to the README PR-URL: https://github.com/nodejs/node/pull/4578 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Colin Ihrig authored
Refs: https://github.com/nodejs/node/issues/3254 PR-URL: https://github.com/nodejs/node/pull/4540 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/4549 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
General improvements to crypto.markdown including new and revised examples. PR-URL: https://github.com/nodejs/node/pull/4435 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Ali Ijaz Sheikh authored
This backport fixes a performance pathology in how arrays grow/shrink. Fixes: https://github.com/nodejs/node/issues/3538 V8-Commit: https://github.com/v8/v8/commit/066747ea053012a99e0cd3e20f36b8ed053b2124 PR-URL: https://github.com/nodejs/node/pull/4625 Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com> Original commit message: Make sure that NormalizeElements and ShouldConvertToFastElements are … …based on the same values BUG=v8:4518 LOG=n Review URL: https://codereview.chromium.org/1472293002 Cr-Commit-Position: refs/heads/master@{#32265}
-
- Jan 06, 2016
-
-
-
Jeremiah Senkpiel authored
* http: - A new status code was added: 451 - "Unavailable For Legal Reasons" (Max Barinov) https://github.com/nodejs/node/pull/4377 - Idle sockets that have been kept alive now handle errors (José F. Romaniello) https://github.com/nodejs/node/pull/4482 * This release also includes several minor performance improvements: - assert: deepEqual is now speedier when comparing TypedArrays (Claudio Rodriguez) https://github.com/nodejs/node/pull/4330 - lib: Use arrow functions instead of bind where possible (Minwoo Jung) https://github.com/nodejs/node/pull/3622 - node: Improved accessor perf of process.env (Trevor Norris) https://github.com/nodejs/node/pull/3780 - node: Improved performance of process.hrtime() (Trevor Norris) https://github.com/nodejs/node/pull/3780, (Evan Lucas) https://github.com/nodejs/node/pull/4484 - node: Improved GetActiveHandles performance (Trevor Norris) https://github.com/nodejs/node/pull/3780 - util: Use faster iteration in util.format() (Jackson Tian) https://github.com/nodejs/node/pull/3964 PR-URL: https://github.com/nodejs/node/pull/4547
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/4547 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Shigeki Ohtsu authored
The description of "[start[, end]]" in the doc shows warning of "invalid param" when parsing an optional parameter in the section. This fixes insufficient trimming of right square brackets. PR-URL: https://github.com/nodejs/node/pull/4537 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Shigeki Ohtsu authored
tools/doc/html.js in make doc throws an error in checking a heading level in the markdown file. PR-URL: https://github.com/nodejs/node/pull/4537 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/4536 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
Remove unused vars in tests PR-URL: https://github.com/nodejs/node/pull/4536 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Conflicts: test/parallel/test-timers-throw-when-cb-not-function.js
-
Dave authored
PR-URL: https://github.com/nodejs/node/pull/4534 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Richard Sun authored
PR-URL: https://github.com/nodejs/node/pull/4538 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Julien Gilli authored
1c858499 "fixed" test-domain-exit-dispose-again by changing its logic to test that process.domain was cleared properly in case an error was thrown from a timer's callback. However, it became clear when reviewing a recent change that refactors lib/timers.js that it was not quite the intention of the original test. Thus, this change adds the original implementation of test-domain-exit-dispose-again back, with comments that make its implementation easier to understand. It also preserve the changes made by 1c858499, but it moves them to a new test file named test-timers-reset-process-domain-on-throw.js. PR: #4256 PR-URL: https://github.com/nodejs/node/pull/4256 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
Remove all remaining unused variables from tests in test/parallel. PR-URL: https://github.com/nodejs/node/pull/4511 Reviewed-By:
James M <Snell<jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rich Trott authored
Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: https://github.com/nodejs/node/issues/3956 PR-URL: https://github.com/nodejs/node/pull/4510 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M <Snell<jasnell@gmail.com>
-
José F. Romaniello authored
This change adds a new event handler to the `error` event of the socket after it has been used by the http_client. The purpose of this change is to catch errors on *keep alived* connections from idle sockets that otherwise will cause an uncaugh error event on the application. Fix: #3595 PR-URL: https://github.com/nodejs/node/pull/4482 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-