- May 05, 2020
-
-
Michaël Zasso authored
Notable changes: * Track function calls with `assert.CallTracker` (experimental). https://github.com/nodejs/node/pull/31982 * Added a `groupIndentation` option to the `Console` constructor. https://github.com/nodejs/node/pull/32964 PR-URL: https://github.com/nodejs/node/pull/33232
-
- May 04, 2020
-
-
Ruben Bridgewater authored
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by:
Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33124 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Robert Nagy authored
If socket creation failed then an error would be emitted on the client request object, but not 'close' nor would destroyed be set to true. PR-URL: https://github.com/nodejs/node/pull/33178 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/33151 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/33203 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Daniele Belardi authored
Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/nodejs/node/pull/31906 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Robert Nagy authored
unshifting into an empty array is the same as creating a new array. PR-URL: https://github.com/nodejs/node/pull/33200 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By:
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/33180 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Rich Trott authored
New version of remark-preset-lint-node includes prohibited string entry accidentally removed in the last version. PR-URL: https://github.com/nodejs/node/pull/33157 Reviewed-By:
-
Kevin Locke authored
This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Juan José Arboleda authored
Collaborators won't need to run CI on documentation-only changes. PR-URL: https://github.com/nodejs/node/pull/33101 Reviewed-By:
-
白一梓 authored
Change `64kb` to `64KB` in `stream.md` PR-URL: https://github.com/nodejs/node/pull/31561 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Owen Smith authored
Previous location of setting the timeout would override behaviour of custom HttpAgents' keepSocketAlive. Moving it into the default keepSocketAlive allows it to interoperate with custom agents. Fixes: https://github.com/nodejs/node/issues/33111 PR-URL: https://github.com/nodejs/node/pull/33127 Reviewed-By:
-
Anna Henningsen authored
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: https://github.com/nodejs/node/pull/32776#issuecomment-620407014 PR-URL: https://github.com/nodejs/node/pull/33129 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Anna Henningsen authored
Original commit message: [arraybuffer] Clean up BackingStore even if it pointer to nullptr For a zero-length BackingStore allocation, it is valid for the underlying memory to be a null pointer. However, some cleanup is still necessary, since the BackingStore may hold a reference to the allocator itself, which needs to be released when destroying the `BackingStore` instance. Change-Id: I1f168079d39e4592d2fde31fbe5f705586690e85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169646 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67420} Refs: https://github.com/v8/v8/commit/e29c62b7485462c1ce8f4129b26e7f7a4d4b193c PR-URL: https://github.com/nodejs/node/pull/33125 Reviewed-By:
-
Anna Henningsen authored
This test can fail when run in parallel with test-process-title-cli, which also sets the process title, which is global state on Windows. Example failure (note that `foo` does not appear in test-process-title but in test-process-title-cli): not ok 1727 parallel/test-process-title --- duration_ms: 0.156 severity: fail exitcode: 1 stack: |- assert.js:103 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + 'foo' - 'd:\\a\\node\\node\\out\\Release\\node.exe' at Object.<anonymous> (d:\a\node\node\test\parallel\test-process-title.js:22:1) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) at internal/main/run_main_module.js:17:47 { generatedMessage: true, code: 'ERR_ASSERTION', actual: 'foo', expected: 'd:\\a\\node\\node\\out\\Release\\node.exe', operator: 'strictEqual' } ... (from https://github.com/nodejs/node/runs/628144750?check_suite_focus=true) PR-URL: https://github.com/nodejs/node/pull/33150 Reviewed-By: -
Robert Nagy authored
finished would incorrectly believe that a Duplex is already closed if either the readable or writable side has completed. Fixes: https://github.com/nodejs/node/issues/33130 PR-URL: https://github.com/nodejs/node/pull/33133 Reviewed-By:
-
Joyee Cheung authored
https://github.com/nodejs/node-v8/pull/147 broke the `vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and without actually calling `v8::Isolate::MeasureMemory()` so the returned promise will never resolve. This was not caught by the tests because the promise resolvers were not wrapped with `common.mustCall()`. This patch migrates the API properly and also introduce the newly added execution option to the API. It also removes support for specifying contexts to measure - instead we'll just return the measurements for all contexts in the detailed mode, which is what the `performance.measureMemory()` prototype in V8 currently does. We can consider implementing our own `v8::MeasureMemoryDelegate` to select the target context in `ShouldMeasure()` in the future, but then we'll also need to implement `MeasurementComplete()` to assemble the result. For now it's probably too early to do that. Since this API is still experimental (and guarded with a warning), such breakage should be acceptable. Refs: https://github.com/nodejs/node-v8/pull/147 PR-URL: https://github.com/nodejs/node/pull/32988 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32899 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/33086 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Daniel Bevenius authored
Currently, the following warning is generated from the inspector protocol: /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp: In member function ‘virtual std::unique_ptr<node::inspector::protocol::Value> node::inspector::protocol::ListValue::clone() const’: /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:739:21: error: redundant move in return statement [-Werror=redundant-move] 739 | return std::move(result); | ~~~~~~~~~^~~~~~~~ This commit removes the move for DictionaryValue and ListValue. PR-URL: https://github.com/nodejs/node/pull/32685 Reviewed-By: -
Daniel Bevenius authored
This commit adds a configuration time flag named error-on-warn: $ ./configure --help | grep -A1 error-on-warn --error-on-warn Turn compiler warnings into errors for node core sources. The motivation for this is that CI jobs can use this flag to turn warnings into errors. PR-URL: https://github.com/nodejs/node/pull/32685 Reviewed-By: -
Anna Henningsen authored
`sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: https://github.com/nodejs/node/pull/33115 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/33114 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Anna Henningsen authored
This closes a memory leak. PR-URL: https://github.com/nodejs/node/pull/33113 Reviewed-By:
Gus Caplan <me@gus.host>
-
Anna Henningsen authored
As this is allocated with `Calloc()`, we cannot use `delete[]` here. PR-URL: https://github.com/nodejs/node/pull/33110 Reviewed-By:
-
James M Snell authored
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by:
Sam Roberts <vieuxtech@gmail.com>
-
James M Snell authored
Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by:
-
James M Snell authored
This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: https://github.com/nodejs/node/pull/33106 Reviewed-By:
-
James M Snell authored
Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379 ) So far, this is only used by the QUIC PR directly but the change itself is independent of QUIC, even if not used directly by anything else yet. Separated out per request. Signed-off-by:
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/33088 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to `Readable.from`. Also added docs for the same. Co-Authored-By:
-
Anna Henningsen authored
Add `stackSizeMb` to the `resourceLimit` option group. Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820 PR-URL: https://github.com/nodejs/node/pull/33085 Reviewed-By:
-
Anna Henningsen authored
Mostly, this introduces a pattern that makes sure that if a custom error is reported, `stopped_` will be set to `true` correctly in every cast, which was previously missing for the `NewContext().IsEmpty()` case (which led to a hard crash from the `Worker` destructor). This also leaves TODO comments for a few cases in which `ERR_WORKER_OUT_OF_MEMORY` was not used in accordance with the documentation for that error code (or according to its intention). Fixing that is semver-major. PR-URL: https://github.com/nodejs/node/pull/33084 Reviewed-By:
-
Colin Ihrig authored
Fix the 'uncaugth' typo in the test name. PR-URL: https://github.com/nodejs/node/pull/33083 Reviewed-By:
-
Ranjan Purbey authored
In the worker pool example, the 'kWorkerFreedEvent' should be emitted in case of error as well. After adding new worker in the error handler, the pending tasks should be notified of an available worker. PR-URL: https://github.com/nodejs/node/pull/33082 Reviewed-By:
-
Chris Holland authored
PR-URL: https://github.com/nodejs/node/pull/33081 Reviewed-By:
-
Robert Nagy authored
Instead of reimplementing Writable properties, fetch them from the Writable prototype. PR-URL: https://github.com/nodejs/node/pull/33079 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32956 Reviewed-By:
-
